Fix DEIM system construction by completing system before return#122
Merged
Conversation
Co-authored-by: Aayush Sabharwal <aayush.sabharwal@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DEIM tutorial is broken due to changes in ModelingToolkit.jl. After calling
deim(), attempting to create anODEProblemfrom the returned system fails.ModelOrderReduction.jl/docs/src/tutorials/deim_FitzHugh-Nagumo.md
Lines 135 to 140 in 97aa0bc
Add a call to
complete(sys)at the end of thedeim()function before returning. According to the ModelingToolkit documentation,complete()marks a system as finalized and performs necessary preprocessing to register all components in the global structure. This allows subsequent operations likeODEProblemconstruction to correctly find all required variables and their initial conditions.